System.Data.SQLite

I'm looking into access violations we get when disposing commands and noticed that in SQLiteDataReader's Close() method it closes the connection before it closes the command.

 

        // If the datareader's behavior includes closing the connection, then do so here.
        if ((_commandBehavior & CommandBehavior.CloseConnection) != 0 && _command.Connection != null)
          _command.Connection.Close();

        if (_disposeCommand)
          _command.Dispose();

shouldn't that be the other way around? Close the command first?

        SQLiteConnection cnn = _command.Connection;

        if (_disposeCommand)
          _command.Dispose();

        // If the datareader's behavior includes closing the connection, then do so here.
        if ((_commandBehavior & CommandBehavior.CloseConnection) != 0 && cnn != null)
          cnn.Close();

 

Thanks, Sam

After making the above change we were able to start disposing SQLiteCommand objects and have not gotten any access violations (which we did get previously when disposing commands--that's why we stopped calling Dispose on commands).

Thanks,

Sam